Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing languages in stats from product_details. #10595

Merged
merged 2 commits into from Feb 5, 2019

Conversation

EnTeQuAk
Copy link
Contributor

@EnTeQuAk EnTeQuAk commented Feb 5, 2019

Some parts actually... need all the languages.

Fixes mozilla/addons#891

Some parts actually... need all the languages.

Fixes mozilla/addons#891
@EnTeQuAk EnTeQuAk requested a review from diox February 5, 2019 07:20
Copy link
Member

@diox diox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke some python 3 tests :)

'english': u'Welsh',
'native': u'Cymraeg'
},
u'dbg': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need that one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, removed in 175d9cd

@EnTeQuAk
Copy link
Contributor Author

EnTeQuAk commented Feb 5, 2019

175d9cd should fix the py3 tests, I probably should start running all (py3 and py2) tests locally first at some point.

@EnTeQuAk EnTeQuAk requested a review from diox February 5, 2019 10:07
@EnTeQuAk EnTeQuAk merged commit 66a9774 into master Feb 5, 2019
@EnTeQuAk EnTeQuAk deleted the 891-fix-stats-langs branch February 5, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants