Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure auto-approve runs everything on primary database #12904

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

diox
Copy link
Member

@diox diox commented Nov 19, 2019

Fixes mozilla/addons#7128

Added a couple other commits to help in the future:

  • A couple functional tests (were passing already)
  • Re-using instance instead of passing the id in run_action() since it's not a real task

Since it's not a real task, might as well pass the version instance,
so that we don't have to reload it in the caller to benefit from the
changes made by the action.
@diox diox force-pushed the auto-approval-delayed-from-scanner-action branch from 2ca2aa5 to f3e63f1 Compare November 19, 2019 15:18
@diox diox requested a review from willdurand November 19, 2019 16:10
@diox diox merged commit e0219f1 into mozilla:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants