Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon.guid is not None for reused guids! #14423

Merged
merged 1 commit into from May 28, 2020
Merged

Addon.guid is not None for reused guids! #14423

merged 1 commit into from May 28, 2020

Conversation

eviljeff
Copy link
Member

@eviljeff eviljeff requested review from a team and diox and removed request for a team May 28, 2020 12:01
@eviljeff
Copy link
Member Author

If only a young(er) naive(r) developer hadn't changed the logic in #1471 so Addon.guid wasn't set to None any more.

@eviljeff eviljeff merged commit b44447e into mozilla:master May 28, 2020
@eviljeff eviljeff mentioned this pull request May 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diox diox diox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@eviljeff @diox