Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support page link in content review page #14638

Merged
merged 1 commit into from Jun 17, 2020

Conversation

linzichao
Copy link
Contributor

Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've included an extra xpi file.

<tr>
<th>{{ _('Support Website') }}</th>
<td>
<strong><a href="{{ addon.support_url }}">{{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the homepage link above, this url needs the external_url filter adding to it (it wraps the link in redirection service for safety)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@linzichao
Copy link
Contributor Author

My bad. I exclude the file from the commit.

@linzichao linzichao requested a review from eviljeff June 17, 2020 08:45
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ great, thanks

@eviljeff eviljeff merged commit c051b5d into mozilla:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants