Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the icon, text and link of mailing list in connect section #16988

Conversation

kanish671
Copy link
Contributor

@kanish671 kanish671 commented Apr 20, 2021

Fixes #16750

The link is currently dead and it has been updated to point to https://discourse.mozilla.org/c/add-ons/.
The text has been updated to Community forum and the icon changed to the Matrix one.

Thanks for opening a Pull Request (PR), here's a few guidelines as to what we need in your PR before we review it.

Please delete anything that isn't relevant to your patch.

  • This PR relates to an existing open issue and there are no existing PRs open for the same issue.
  • Add Fixes #ISSUENUM at the top of your PR.
  • Add a description of the changes introduced in this PR.
  • The change has been successfully run locally.
  • Add before and after screenshots (Only for changes that impact the UI).

The link is currently dead and need to be updated to point to Community
forum. The text needs to be changed to Community forum and the icon needs
to be updated to the same as that of Matrix.
@kanish671 kanish671 changed the title Changed the icon, text and link of mailing list in connect.html Changed the icon, text and link of mailing list in connect section Apr 20, 2021
Copy link
Member

@eviljeff eviljeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks

@eviljeff eviljeff merged commit 8c8b336 into mozilla:master Apr 21, 2021
@kanish671 kanish671 deleted the issue/16750-broken-add-on-developers-mailing-list branch April 21, 2021 15:26
@caitmuenster
Copy link

Thanks so much for the patch, @kanish671! 🎉 Your contribution has been added to our recognition wiki.

Welcome onboard! We look forward to seeing you around.

@kanish671
Copy link
Contributor Author

Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken "Add-ons developers mailing list" link
3 participants