Remove fill="context-fill" and fill-opacity="context-fill-opacity" from Hero SVGs
#22267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
changed the title
fill="context-fill" and fill-opacity="context-fill-opacity"` from Hero SVGsfill="context-fill" and fill-opacity="context-fill-opacity" from Hero SVGs
diox
force-pushed
the
remove-fill-context-fill-from-hero-svgs
branch
from
33413b2
to
afd2433
Compare
… from Hero SVGs This was preventing them from being displayed when loaded as <img> in Chrome and some image viewers. We are not using them as masks so that shouldn't matter.
diox
force-pushed
the
remove-fill-context-fill-from-hero-svgs
branch
from
afd2433
to
a12c149
Compare
KevinMind
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was preventing them from being displayed when loaded as
<img>in Chrome and some image viewers. We are not using them as masks so that shouldn't matter.Fixes mozilla/addons#1771
See issue for STRs and screenshots of the breakage - this was visible in the homepage on Chrome or in the django admin hero pages.