Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove perf #2566

Merged
merged 1 commit into from May 9, 2016
Merged

remove perf #2566

merged 1 commit into from May 9, 2016

Conversation

andymckay
Copy link

No description provided.

@tofumatt
Copy link
Contributor

tofumatt commented May 6, 2016 via email

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented May 6, 2016

This branch doesn't just remove olympia.perf but adds coverage tracking, can we split those please?

@andymckay
Copy link
Author

I give up on coveralls, cannot get py.test to pickup pytest-cov, works locally just fine, but theres always that fun difference that travis use tox which is completely different from our local environments see also issue mozilla/addons#2401.

@EnTeQuAk
Copy link
Contributor

EnTeQuAk commented May 9, 2016

How that the coverage stuff is not in the PR anymore, lgtm

r+

Should we open a github issue for properly integrating coveralls?

@andymckay andymckay merged commit 1ae9f63 into mozilla:master May 9, 2016
@andymckay
Copy link
Author

Maybe, do developers want coveralls in?

@EnTeQuAk
Copy link
Contributor

having an automatic coverage report is quite nice, it's more important for library-owners but if it works and the effort is reasonable, let's do it. Or at least try to integrate it at some point. I doubt it's important though.

@diox
Copy link
Member

diox commented May 10, 2016

Do consider alternatives to coveralls though, like https://codecov.io/ ? I don't know which one is the best, I just had to fight with coveralls in the past so maybe there are decent alternatives we should explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants