Fixes some failing tests on jenkins #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
magopian
commented
Apr 2, 2014
magopian
commented
- apps.users.tests.test_views.TestReset.test_reset_fails, apps.users.tests.test_views.TestReset.test_reset_msg: introduced in d1e14c4
- apps.devhub.tests.test_views.TestDashboard.test_sort_created_filter: introduced in ad4ecea
- apps.api.tests.test_urls:TestDRFSwitch.test_responses: introduced in 5ab4b4a
- tests failing because of calls to persona
| @@ -232,7 +232,7 @@ def test_sort_created_filter(self): | |||
| d = doc('.item-details .date-created') | |||
| eq_(d.length, 1) | |||
| eq_(d.remove('strong').text(), | |||
| strip_whitespace(datetime_filter(addon.created, '%b %e, %Y'))) | |||
| datetime_filter(addon.created, '%b %e, %Y')) | |||
There was a problem hiding this comment.
We are now using %e which replaces the 0 in the day number (eg 02) by a space. We can't use %b%e because when there's no 0, there's no space at all. So we need to keep this extraneous space (which isn't visible when the html is rendered), and thus can't match if we use strip_whitespace in the test.
|
r+wc |
magopian
added a commit
that referenced
this pull request
Apr 3, 2014
Fixes some failing tests on jenkins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.