Add experimental addon flag to submission, edit listing; #3178
Conversation
|
@jvillalobos is the copy okay? I can add screenshots if that helps. |
| @@ -98,6 +98,10 @@ | |||
| This add-on has been preliminarily reviewed by Mozilla. | |||
| <a href="{{ url }}">Learn more</a> | |||
| {% endtrans %} </p> | |||
| {% elif b.experimental %} | |||
| <p class="warning">{% trans url=url('pages.faq') + "#preliminary" %} | |||
| This add-on has been flagged as experimental by its developers. | |||
There was a problem hiding this comment.
"Flagged" may have negative connotations. "Marked"?
eviljeff
force-pushed
the
i3083-experimental-flag
branch
2 times, most recently
from
d706a98
to
34fb586
Compare
|
@diox can you especially check I added the property to ES and the API response correctly - my ES locally was playing up so it was difficult to check everything was working as expected. |
| @@ -77,6 +77,7 @@ def get_mapping(cls): | |||
| 'hotness': {'type': 'double'}, | |||
| 'icon_type': {'type': 'string', 'index': 'no'}, | |||
| 'is_disabled': {'type': 'boolean'}, | |||
| 'is_experimental': {'type': 'boolean'}, | |||
There was a problem hiding this comment.
I assume we don't need to search on it, so you can add 'index': 'no'
There was a problem hiding this comment.
We could feasibly need to search on it - it's a psuedo-status - so I guess it should be treated how status is.
There was a problem hiding this comment.
Yeah and actually you're searching on it - in the legacy api search view. Carry on.
eviljeff
force-pushed
the
i3083-experimental-flag
branch
from
34fb586
to
3fbe780
Compare
|
You're missing a test that proves the devhub shows the field (with the correct value) when the waffle is on r+with that |
eviljeff
force-pushed
the
i3083-experimental-flag
branch
from
3fbe780
to
7fab9e5
Compare
show different install button; degrade search ranking.
eviljeff
force-pushed
the
i3083-experimental-flag
branch
from
7fab9e5
to
6bf19c8
Compare
show different install button; degrade search ranking. Fixes mozilla/addons#3290