Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message details to bulk validation summary page #4122

Merged
merged 1 commit into from Dec 8, 2016
Merged

Add message details to bulk validation summary page #4122

merged 1 commit into from Dec 8, 2016

Conversation

wagnerand
Copy link
Member

I wasn't able to test this properly due to the lack of data.

EnTeQuAk
EnTeQuAk reviewed Dec 7, 2016
View reviewed changes
Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far but I'd feel safer adding at least a small unittest to zadmin.tests.test_views:TestBulkValidation.test_bulk_validation_summary_detail if that's possible. Also, this test is apparently failing in travis.

@wagnerand
Copy link
Member Author

✔️ Test fixed
✔️ Additional test checks added

EnTeQuAk
EnTeQuAk approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@EnTeQuAk EnTeQuAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

lgtm

@wagnerand
Copy link
Member Author

Thanks!

@wagnerand wagnerand merged commit a2ce05d into mozilla:master Dec 8, 2016
@wagnerand wagnerand deleted the bulk_val branch December 8, 2016 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EnTeQuAk EnTeQuAk EnTeQuAk approved these changes

Assignees

@EnTeQuAk EnTeQuAk

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wagnerand @EnTeQuAk