Localize review API error messages #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
approved these changes
Feb 10, 2017
| @@ -96,7 +98,7 @@ def validate(self, data): | |||
| # Only one level of replying is allowed, so if it's already a | |||
| # reply, we shouldn't allow that. | |||
| raise serializers.ValidationError( | |||
| 'Can not reply to a review that is already a reply.') | |||
| _(u"You can't reply to a review that is already a reply.")) | |||
There was a problem hiding this comment.
How about this?
"You can't reply to review comments."
There was a problem hiding this comment.
mmm I'm not a fan. "review comments" is vague... I don't think addons-frontend support this yet, but this message should not be shown to users (only developers can reply, and a reply button should never be shown on a reply)
There was a problem hiding this comment.
Yeah, it's no biggie. Your original message works. I agree that it probably won't ever be shown to the user (if so, it will be a UI bug).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mozilla/addons#4022