Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix search-on-click #4691
@numrut I think for this to work the value of the un-escaped search value needs to be run through encodeURIComponent and then HTML escaped afterwards. Otherwise the urlencoding is going to escape the
See http://jsbin.com/cokacoh/edit?js,console,output which highlights the differences.
See also the difference between submitting a search containing HTML on production versus running this current version of your patch.
There are many possible solutions:
Which one should we choose?