In API make homepage and support_url go through outgoing url transform #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
approved these changes
Feb 17, 2017
src/olympia/addons/serializers.py
Outdated
| data.pop('theme_data') | ||
| if 'homepage' in self.fields: | ||
| data['homepage'] = self.outgoingify(data['homepage']) |
There was a problem hiding this comment.
I assume there's no chance that a field can be in self.fields but not in data?
There was a problem hiding this comment.
That should not happen, no, but maybe I should just do in data instead of in self.fields, I'll look into that.
There was a problem hiding this comment.
That would put the field in data if it was absent, which isn't ideal
diox
force-pushed
the
api-outgoing-urls
branch
from
fc9354e
to
a2efc3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mozilla/addons#3885