Don't try to sign if file is missing (bug 1164390) #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.version.sign_files() | ||
| # 'sign_file' got called twice, but only one was signed. | ||
| call_signing_mock.assert_called_once_with( | ||
| good_file.file_path, 'endpoint', good_file.version.addon.guid) |
There was a problem hiding this comment.
I don't see how this test is testing the code. I would expect to remove a file rather than copy one?
There was a problem hiding this comment.
There's already a file in the fixture, but it doesn't have a real file on the disk (it's just a db fixture).
That's why I'm adding another File with a file on disk. This is the one that needs to get signed (and the original one not having a file on disk shouldn't prevent that).
|
r+ |
magopian
added a commit
that referenced
this pull request
May 13, 2015
Don't try to sign if file is missing (bug 1164390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 1164390