FIxes #7646 - Theme name field is not updated when changing the image #7761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the opposite of what the discussion was in the issue though. You should check there is you're proposing a different "fix" (editing the existing comment doesn't count - no-one gets a notification) |
|
Ok will do! |
|
Closing this issue together with mozilla/addons#5294, see my explanation in that issue for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#5294 - Removed functionality to automatically populate the Theme Name upon uploading a header image.
Reason behind change:
The current functionality automatically populates the theme name (if empty) with the file name of the uploaded header image. In most cases, this file name does not translate into a professional and unique theme name that accurately represents the created theme. After speaking with some individuals (a very small sample size of 5), all entered the Theme name first and didn't expect the uploaded header image file name to be used at all.
Before GIF:
After GIF: