Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up forced 404 routes once new nginx config is released #10270

Closed
muffinresearch opened this issue Mar 17, 2017 · 1 comment · Fixed by mozilla/addons-frontend#2347
Closed
Assignees
Labels
repository:addons-frontend Issue relating to addons-frontend
Milestone

Comments

@muffinresearch
Copy link
Contributor

Once the nginx configs from #10266 are rolled out to stage and prod it would be good to remove the forced 404 routes that should no longer be needed.

See https://github.com/mozilla/addons-frontend/blob/c8e567e7b6b7098368123d12fa698855c8e00d44/src/amo/routes.js#L32

@kumar303
Copy link
Contributor

kumar303 commented May 3, 2017

This will be a little confusing (for local development only) since we won't see 404s anymore. I think we can get back to 404s after #10363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repository:addons-frontend Issue relating to addons-frontend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants