Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up 404 routes that we don't need anymore #2347

Merged
merged 2 commits into from
May 3, 2017

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented May 3, 2017

@kumar303
Copy link
Contributor Author

kumar303 commented May 3, 2017

@muffinresearch re: mozilla/addons#10266 ...

I'll add comments to the routes to make it clear that ops need to be told when new routes are added.

Did that comment ever get added? Should I add it?

@muffinresearch
Copy link
Contributor

Did that comment ever get added? Should I add it?

Oops, I think that slipped through the net. Good catch - please do.

@muffinresearch
Copy link
Contributor

Since it doesn't matter leaving these, would it be worth folding this into the react-router upgrade to avoid having any weird falling-through locally?

Copy link
Contributor

@muffinresearch muffinresearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

@kumar303
Copy link
Contributor Author

kumar303 commented May 3, 2017

would it be worth folding this into the react-router upgrade to avoid having any weird falling-through locally?

I think it's ok to do the two patches independently. The lack of 404 routes will cause a 500 locally which isn't really any more or less helpful than a 404.

@kumar303 kumar303 merged commit a611f0a into mozilla:master May 3, 2017
@kumar303 kumar303 deleted the cleanup-404s-iss2088 branch May 3, 2017 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean-up forced 404 routes once new nginx config is released
2 participants