Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show if addon can be installed in listings/seach results #2886

Closed
Archaeopteryx opened this issue Apr 10, 2016 · 11 comments
Closed

Always show if addon can be installed in listings/seach results #2886

Archaeopteryx opened this issue Apr 10, 2016 · 11 comments
Assignees

Comments

@Archaeopteryx
Copy link

Example search

Always show if an addon can be installed in listings/seach results so one can easily view of a search yielded something useful for not or which addon can be installed.

@pwalm
Copy link
Contributor

pwalm commented Apr 13, 2016

Ideally, we just shouldn't show it. Can we do that? If you can't install it on your platform, you don't see it.

@pwalm
Copy link
Contributor

pwalm commented Apr 13, 2016

(I believe we did this with Marketplace)

@andymckay
Copy link

We can, but that's beyond a style change and I think we might want to think about the implications of that. In the old AMO if you couldn't install something it was clear in the search results, by being greyed out..?

@Archaeopteryx
Copy link
Author

If I remember correct, there was a transparency applied to the listing so everything looked lighter.

@tofumatt
Copy link
Contributor

There was a transparency applied; in fact we should have fixed this with transparency (#2024) but it seems it's not showing.

There is supposed to be a class applied to the div containing the add-on but it doesn't seem to be getting applied.

@tofumatt tofumatt assigned tofumatt and unassigned pwalm Apr 13, 2016
tofumatt referenced this issue in mozilla/addons-server Apr 13, 2016
Modify the opacity of unsupported add-ons (fix #2289)
@tofumatt
Copy link
Contributor

This might need some extra QA magnifying glasses, as this probably affects a fair number of pages. I tested the listings and version page.

@ValentinaPC
Copy link

@tofumatt : Can we apply this to themes as well?

@ValentinaPC
Copy link

Does this require another issue to be logged or should we reopen this?
Verified on AMO-dev FF45(Win 7) in https://addons-dev.allizom.org/en-US/firefox/extensions/bookmarks/?sort=popular .
Please see the screencast: http://screencast.com/t/Iv3Ago5kAk

@tofumatt
Copy link
Contributor

We can apply it to themes as well, but it should be a separate bug.

  • tofumatt

On 14 April 2016 at 09:46:38, ValentinaPC (notifications@github.com) wrote:

Does this require another issue to be logged or should we reopen this?
Verified on AMO-dev FF45(Win 7) in
https://addons-dev.allizom.org/en-US/firefox/extensions/bookmarks/?sort=popular
.
Please see the screencast: http://screencast.com/t/Iv3Ago5kAk


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2886

@tofumatt
Copy link
Contributor

Does this require another issue to be logged or should we reopen this?
Verified on AMO-dev FF45(Win 7) in https://addons-dev.allizom.org/en-US/firefox/extensions/bookmarks/?sort=popular .
Please see the screencast: http://screencast.com/t/Iv3Ago5kAk

Please file a separate bug for this as well. It's definitely a bug, but it shouldn't block release.

@ValentinaPC
Copy link

I've logged separate issues.
I've verified this all around AMO-dev in FF45(Win 7).
Postfix screenshots:
2016-04-14_1959
2016-04-14_2000

@KevinMind KevinMind transferred this issue from mozilla/addons-server May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants