Use python-spidermonkey module for Spidermonkey binary. #312
Conversation
kmaglione
force-pushed
the
python-spidermonkey
branch
2 times, most recently
from
8414c92
to
6c775fe
Compare
kmaglione
force-pushed
the
python-spidermonkey
branch
from
6c775fe
to
9cd5840
Compare
kmaglione
changed the title
|
I think this is ready now. Ideally I'd like to get this merged (but not pushed to production) sometime this week so we can start enabling the validator on Olympia dev builds (especially in Docker) by default. |
| @@ -7,3 +7,4 @@ argparse==1.1 | |||
| fastchardet==0.2.0 | |||
| mock==1.0.0 | |||
| simplejson==3.8.0 | |||
| spidermonkey==41.0a2.post1 | |||
There was a problem hiding this comment.
👍 Do you want me to upload that to pyrepo?
There was a problem hiding this comment.
Yeah, we'll need it there. Do you want me to give you a wheel for Linux? PyPI won't accept it.
There was a problem hiding this comment.
Done: https://pyrepo.addons.mozilla.org/spidermonkey-41.0a2.post1.tar.gz
Not sure we need the wheel for now. It would be a nice speedup, but if it's a pain to create... travis could do it for us, but if it can't be uploaded to pypi...
|
If you don't want it pushed to production this week, please only merge after the tag for this week is done (tomorrow). That's a nice improvement. I'm still a bit confused and lost with all the indirection in the r+wc |
|
If there's anything you want me to explain the rationale for, let me know. It's mostly just a matter of making sure we use a single Spidermonkey process for the entire validation run, but to clean it up at the end, and whenever we run into errors. |
kmaglione
force-pushed
the
python-spidermonkey
branch
from
9cd5840
to
be9bbfe
Compare
kmaglione
changed the title
kmaglione
force-pushed
the
python-spidermonkey
branch
from
be9bbfe
to
2930284
Compare
Use python-spidermonkey module for Spidermonkey binary.
No description provided.