bump spidermonkey

[magopian]

We need a version greater than 43.0a2 for bug 1224444

[magopian]

Those changes are needed for the tests to pass with this version of spidermonkey. Otherwise they raise a syntax error instead.

According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/Legacy_generator_function, "The legacy generator function is a SpiderMonkey-specific feature, and will be removed at some point." (thanks @muffinresearch for digging that up).

[magopian]

@kmaglione would you mind giving this a quick r? please? I'm worried about the syntax change, should we simply go with it?

I've looked through some results on https://mxr.mozilla.org/addons/search?string=yield&find=&findi=&filter=&hitlimit=&tree=addons and found many add-ons using the (now deprecated?) function for generators. If we do upgrade spidermonkey, then we'll break the validation for all of those, right?

[magopian]

As a stop-gap, i've added a version(180) to force the version of js (to not be 185, which deprecates the function for generators, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/Legacy_generator_function)

[EnTeQuAk]

r+