This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Discovery filter #135
Merged
Discovery filter #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Isolated language regex and tested it.
|
@cadecairos r? |
| @@ -6,8 +6,7 @@ CREATE TABLE IF NOT EXISTS "users" | |||
| created_at timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, | |||
| updated_at timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP, | |||
| deleted_at timestamp DEFAULT NULL, | |||
| language varchar NOT NULL DEFAULT 'en', | |||
| country varchar NOT NULL DEFAULT 'US', | |||
| language varchar NOT NULL DEFAULT 'en-US', | |||
There was a problem hiding this comment.
we're going to make the modifications in the migration script, so don't change this here
There was a problem hiding this comment.
actuially nvm, this is cool.
Discovery filter - migration scripts
|
R+ from me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## WARNING: NEEDS MIGRATION TO MERGE COLUMNS FOR EXISTING USERSContributes to fixing #121