Refactor how we handle validity and unknown bookmark types #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kmarks. Some of this logic was written before `set_reupload` and `set_replace` existed. This commit replaces the mix of validity return values and checks with calls to those functions everywhere.
eoger
approved these changes
Mar 10, 2020
|
Do think there are other places that might need a similar fix? I could be a good opportunity for external contributors to explore the code base. |
Definitely, I'll keep an eye out for other small refactors like this! |
We can't support bookmarks with types that we don't know about. Ignoring them is more likely to mask client bugs, and cause problems with the tree structure, than anything else. Let's make this a hard error for now, and monitor telemetry. If these occur frequently, we can explore storing placeholders for them with `Replace` validity.
linabutler
force-pushed
the
small-validity-fixes
branch
from
e925d6b
to
b1743a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small, internal changes:
set_{reupload, replace}consistently when I was making the list of reasons in Dedupe existing bookmark tags and URLs #2775 (comment). The first commit cleans that up.validity = Replace; Dogear would need to grow support for them as well) and replace them with tombstones.Pull Request checklist
automation/all_tests.shruns to completion and produces no failures[ci full]to the PR title.