2334 - Add ttl to get_access_token. #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
jhugman/2334-add-ttl-to-get-access-token
branch
from
7ec224e
to
7cd4bff
Compare
eoger
reviewed
Apr 1, 2020
jhugman
force-pushed
the
jhugman/2334-add-ttl-to-get-access-token
branch
3 times, most recently
from
fd810cb
to
0025e4d
Compare
jhugman
force-pushed
the
jhugman/2334-add-ttl-to-get-access-token
branch
3 times, most recently
from
222382a
to
c5d7da8
Compare
Fixes mozilla#2334. Adds an optional `ttl` parameter to kotlin and swift interfaces, to limit the time that tokens are cached. The FFI uses a `zero` as a default parameter, but this is not exposed to either side of the boundary. This is not expected to be a breaking change for the iOS and Android.
jhugman
force-pushed
the
jhugman/2334-add-ttl-to-get-access-token
branch
from
c5d7da8
to
1ecf3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2334.
Adds an optional
ttlparameter to kotlin and swift interfaces, to limit the time that tokens are cached.The FFI uses a
zeroas a default parameter.This is not expected to be a breaking change for the iOS and Android.
Pull Request checklist
automation/all_tests.shruns to completion and produces no failures[ci full]to the PR title.[ ] Dependencies: This PR follows our dependency management guidelinesAny new dependencies are accompanied by a summary of the due dilligence applied in selecting them.