Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Nimbus-FML) Added first cut design of Intermediate Representation module #4604

Merged
merged 6 commits into from
Oct 22, 2021

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Oct 21, 2021

Fixes SDK-399.

This PR introduces a module to represent a project or apps manifest of features.

Posted up early for feedback from @travis79.

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGES_UNRELEASED.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2021

Codecov Report

Merging #4604 (f3b575d) into main (a5613c6) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4604      +/-   ##
==========================================
+ Coverage   80.63%   80.69%   +0.06%     
==========================================
  Files          51       48       -3     
  Lines        5221     5217       -4     
==========================================
  Hits         4210     4210              
+ Misses       1011     1007       -4     
Impacted Files Coverage Δ
components/support/nimbus-fml/src/lib.rs
components/support/nimbus-fml/src/main.rs
components/support/nimbus-fml/src/parser.rs

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5613c6...f3b575d. Read the comment docs.

Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concerns I have with this is naming it ir. While this is definitely an internal structure and we know what it represents, I lean towards naming this a little more descriptively intermediate_representation is wordy, but that might make where we use it more readable to an outside contributor, for instance. This is a strong opinion, weakly held, and I'm perfectly fine deferring to your preference on this

@jhugman jhugman force-pushed the jhugman/sdk-399-ir-with-examples branch from 17cca24 to 91873e5 Compare October 22, 2021 17:30
Copy link
Member

@travis79 travis79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for diverting on a naming bikeshed, but I think this is better self-documentation.

@jhugman jhugman force-pushed the jhugman/sdk-399-ir-with-examples branch from 0351342 to 11cbf40 Compare October 22, 2021 20:25
@jhugman jhugman merged commit 1dab6d7 into main Oct 22, 2021
@jhugman jhugman deleted the jhugman/sdk-399-ir-with-examples branch October 22, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants