-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Nimbus-FML) Added first cut design of Intermediate Representation module #4604
Conversation
e1126c7
to
d6d6d1d
Compare
Codecov Report
@@ Coverage Diff @@
## main #4604 +/- ##
==========================================
+ Coverage 80.63% 80.69% +0.06%
==========================================
Files 51 48 -3
Lines 5221 5217 -4
==========================================
Hits 4210 4210
+ Misses 1011 1007 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only concerns I have with this is naming it ir
. While this is definitely an internal structure and we know what it represents, I lean towards naming this a little more descriptively intermediate_representation
is wordy, but that might make where we use it more readable to an outside contributor, for instance. This is a strong opinion, weakly held, and I'm perfectly fine deferring to your preference on this
17cca24
to
91873e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry for diverting on a naming bikeshed, but I think this is better self-documentation.
0351342
to
11cbf40
Compare
Fixes SDK-399.
This PR introduces a module to represent a project or apps manifest of features.
Posted up early for feedback from @travis79.
Pull Request checklist
[ci full]
to the PR title.