Ignore clap yaml-rust advisory

[tarikeshaq]

Our dependency advisory CI is failing again... I'm starting to question how useful of a check this is in practice, as opposed to a different advisory checking strategy..

An alternative I'm thinking of:

• When an advisory is detected (we can run a chron job for this, github actions maybe?) that we are impacted by, it creates an issue for it. If one is already created, it's ignored
• When anyone adds a new dependency, the normal "check-dependencies" job runs, we can probably add filters or something to circle CI to only run that job if Cargo.tomls are changed

Anyhoo, I'll create an issue for that, in the meantime:
#4604 added a yaml feature for clap, clap 2.33 uses a version of yaml-rust that has an advisory out. Based on clap-rs/clap#1569 it's a false positive for clap and can be safely ignored. Once clap v3 is out, we can upgrade and we'll get the new version of yaml-rust for free, and thus we can remove the ignore

[codecov-commenter]

Codecov Report

Merging #4611 (c7026d8) into main (5eea186) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4611   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files          48       48           
  Lines        5217     5217           
=======================================
  Hits         4210     4210           
  Misses       1007     1007           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eea186...c7026d8. Read the comment docs.

[travis79]

I was planning on using the serde_yaml crate which also relies on yaml-rust, currently at version 0.4.5. I don't think this is a problem, but I wanted to let you know that clap may not be the only crate with this dependency soon.

[skhamis]

It seems the check-dependencies is still failing but for a different reason -- looks like a switch from master to main might as well regen the deps so get this fully green!