[SDK-416] Fix missing disqualification event after global opt-out #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disqualification events were not being recorded when toggling the global user participation.
jhugman
approved these changes
Oct 26, 2021
| assertEquals("Experiment branch must match", "test-branch", enrollmentEventExtras["branch"]) | ||
| assertNotNull("Experiment enrollment-id must not be null", enrollmentEventExtras["enrollment_id"]) | ||
| } | ||
|
|
| @@ -490,18 +490,25 @@ open class Nimbus( | |||
| internal fun setGlobalUserParticipationOnThisThread(active: Boolean) = withCatchAll { | |||
| val enrolmentChanges = nimbusClient.setGlobalUserParticipation(active) | |||
| if (enrolmentChanges.isNotEmpty()) { | |||
| recordExperimentTelemetryEvents(enrolmentChanges) | |||
No, Swift already handles this correctly. I could add tests in Swift to match the tests I added here, if you like. |
travis79
force-pushed
the
sdk-416
branch
3 times, most recently
from
65a0909
to
24b5aa3
Compare
Codecov Report
@@ Coverage Diff @@
## main #4606 +/- ##
=======================================
Coverage 80.69% 80.69%
=======================================
Files 48 48
Lines 5217 5217
=======================================
Hits 4210 4210
Misses 1007 1007 Continue to review full report at Codecov.
|
This was referenced Oct 27, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disqualification events were not being recorded when toggling the global user participation.