Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrades appservices to 86.2.0 #11181

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

tarikeshaq
Copy link
Contributor

Upgrades application services to 86.1.0. It's a non-breaking change with some improvement and bug fixes.

We're hoping to get this in for v95

Changelog:

v86.1.0 (2021-10-27)

Full Changelog

⛅️🔬🔭 Nimbus

What's New

  • Rollouts: allows winning branch promotion and targeting rollouts of features. #4567.
    • for both Android and iOS.

What's fixed

  • Fixed a bug in iOS where the installation date would be set to start of EPOCH (#4597)
  • Fixed a bug in Android where we were missing disqualification events after a global opt-out (#4606)

Push

  • We've changed how the push database is opened, which should mean we now automatically handle
    some kinds of database corruption.

General

What's changed

  • The bundled version of Glean has been updated to v42.0.1.
    See the Glean Changelog for full details.
    (Note there is a breaking change in Rust, but that doesn't impact consumers of Application Services)

@tarikeshaq tarikeshaq requested a review from a team as a code owner October 27, 2021 17:12
@tarikeshaq
Copy link
Contributor Author

tarikeshaq commented Oct 27, 2021

@grigoryk @csadilek , we missed it in the changelog - but this has a useful change related to the recent logins work, removing many (some? not sure about the severity) logs from sentry that shouldn't have been a sentry errors, ref: mozilla/application-services@73b922e
(cc: @bendk)

We probably want to get this in before the end of the cycle to prevent the logs from crowding sentry

@tarikeshaq
Copy link
Contributor Author

As per the discussion in slack, I opened #11192 that includes only the logins changes, this PR can wait till next cycle

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

This pull request has conflicts when rebasing. Could you fix it @tarikeshaq? 🙏

@jonalmeida
Copy link
Contributor

bors try

@bors
Copy link

bors bot commented Nov 1, 2021

try

Merge conflict.

@tarikeshaq tarikeshaq changed the title Upgrades appservices to 86.1.0 Upgrades appservices to 86.2.0 Nov 2, 2021
@tarikeshaq
Copy link
Contributor Author

We released 86.2.0, so updated this PR to update to that instead! In addition to the changelog above, the changelog for 86.2.0:

v86.2.0 (2021-11-02)

Full Changelog

Push

What's Changed

  • We've changed the database schema to avoid confusion about the state of subscriptions and
    in particular, avoid SQL: UNIQUE constraint failed: push_record.channel_id errors
    reported in #4575. This is
    technically a breaking change as a dictionary described in the UDL changed, but in practice,
    none of our consumers used it, so we are not declaring it as breaking in this context.

Logins

What's New

  • Added support for recording telemetry when the logins encryption key needs to be regenerated.

cc @bendk

@jonalmeida
Copy link
Contributor

bors try

bors bot pushed a commit that referenced this pull request Nov 2, 2021
@bors
Copy link

bors bot commented Nov 2, 2021

try

Build succeeded:

Copy link
Contributor

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this new version with Fenix, looks good to me 👍

@eliserichards
Copy link
Contributor

I'm confirming with the rest of the team before we merge this @tarikeshaq

Copy link
Contributor

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested a fresh and existing install with push, and I did not come across any bugs. I actually think this solved a push bug with web content push too!

r+ and let's land it!

@jonalmeida jonalmeida added the 🛬 needs landing PRs that are ready to land label Nov 9, 2021
@mergify mergify bot merged commit 1c645b6 into mozilla-mobile:main Nov 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants