Add FML command line to nimbus-cli #5784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5784 +/- ##
==========================================
- Coverage 37.13% 36.91% -0.22%
==========================================
Files 330 331 +1
Lines 33150 33051 -99
==========================================
- Hits 12309 12201 -108
- Misses 20841 20850 +9
☔ View full report in Codecov by Sentry. |
jhugman
force-pushed
the
jhugman/exp-3772-fml-from-cli
branch
2 times, most recently
from
e5e8b52
to
3cc2024
Compare
jhugman
force-pushed
the
jhugman/exp-3772-fml-from-cli
branch
from
3cc2024
to
939ec48
Compare
jeddai
approved these changes
Aug 18, 2023
Comment on lines
15
to
28
| // We prepend the string `nimbus-cli fml` to the args to pass to FML | ||
| // because the clap uses the 0th argument for help messages. | ||
| let first = OsStr::new("nimbus-cli fml").to_os_string(); | ||
| let mut cli_args = vec![&first]; | ||
|
|
||
| // To make this a little more ergonomic, if the user has just typed | ||
| // `nimbus-cli fml`, then we can help them a little bit. | ||
| let help = OsStr::new("--help").to_os_string(); | ||
| if args.is_empty() { | ||
| cli_args.push(&help); | ||
| } else { | ||
| cli_args.extend(args); | ||
| } |
There was a problem hiding this comment.
Can you explain this a bit more? Sorry I'm not following the comments well enough to fully understand.
There was a problem hiding this comment.
sure, I'll update the comment; however, let me try here:
clapuses the zeroth argument in the command line in help and error messages, so the FML clap would report an error with a usage messagenimbus-cli fml generate [OPTIONS] <INPUT> <OUTPUT>instead ofnimbus-fml generate [OPTIONS] <INPUT> <OUTPUT>.- If the user types
nimbus-cli fml, it would give a rather unfriendlynot implemented: Command not implemented; if/when we change thenimbus-fmlcli to useclap derive, as we do in the CLI, this would change. Until then, add the--helpflag to display the usage message.
jhugman
force-pushed
the
jhugman/exp-3772-fml-from-cli
branch
from
939ec48
to
4ec178d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXP-3772.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.