Move structure validation to separate structure validator #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5939 +/- ##
==========================================
- Coverage 26.81% 26.74% -0.08%
==========================================
Files 376 377 +1
Lines 47777 47718 -59
==========================================
- Hits 12813 12763 -50
+ Misses 34964 34955 -9 ☔ View full report in Codecov by Sentry. |
jhugman
commented
Nov 22, 2023
| Ok(()) | ||
| } | ||
|
|
||
| pub(crate) fn validate_feature_def(&self, feature_def: &FeatureDef) -> Result<()> { |
There was a problem hiding this comment.
This method is the largest non-mechanical change: here we're aggregating a lot of disparate methods which were all iterating over feature_def.props, and put them all in one loop.
| )], | ||
| false, | ||
| ); | ||
| validator.validate_feature_def(&fm).expect_err( |
There was a problem hiding this comment.
All these tests used to be of the form:
let fm = get_feature_manifest(…)
fm.validate_something()
I've left most of the variable names intact.
jhugman
force-pushed
the
jhugman/exp-3938-move-structure-validation-to-structure-validator
branch
from
9740f54
to
5407918
Compare
jhugman
force-pushed
the
jhugman/exp-3938-move-structure-validation-to-structure-validator
branch
from
5407918
to
3efedc8
Compare
jhugman
deleted the
jhugman/exp-3938-move-structure-validation-to-structure-validator
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to EXP-3938.
According to The Big O of Code Reviews, this is a O(n) change.
This is moving quite a lot of code out
intermediate_representation.rsinto a newstructure/validator.rsfile.The changes are fairly mechanical, but they added up. The tests also changed and moved, so this is a larger O(n) sized.
This has a requirement on landing #5947 and rebasing before this will build.
Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.