Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nimbus-fml command for info #5967

Merged

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Nov 30, 2023

Relates to EXP-3938.

According to The Big O of Code Reviews, this is a O(n) change.

This PR is the final piece in EXP-3938, adding per-feature hashes to the FML.

We end here with an info command to add to the nimbus-fml command line. It outputs JSON / YAML with a summmary of each feature including:

  • the types used, as a proxy for feature complexity
  • feature metadata, including documentation and events
  • the schema hash and defaults hash.

The PRs to get here are:

The final PR (this one):

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jhugman jhugman force-pushed the jhugman/exp-3938-add-hash-to-fml-structure-and-defaults branch 2 times, most recently from 4d204b3 to 0bd68cc Compare November 30, 2023 19:55
@jhugman jhugman requested review from eliserichards, jeddai and brennie and removed request for eliserichards and jeddai November 30, 2023 19:56
@jhugman jhugman force-pushed the jhugman/exp-3938-add-hash-to-fml-structure-and-defaults branch 2 times, most recently from 9ebe6d5 to d79df3a Compare November 30, 2023 20:29
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (6581e46) 27.64% compared to head (b40ec3b) 27.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
components/support/nimbus-fml/src/backends/info.rs 0.00% 41 Missing ⚠️
...s/support/nimbus-fml/src/command_line/workflows.rs 0.00% 12 Missing ⚠️
...ponents/support/nimbus-fml/src/command_line/mod.rs 83.78% 6 Missing ⚠️
...port/nimbus-fml/src/intermediate_representation.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5967   +/-   ##
=======================================
  Coverage   27.64%   27.65%           
=======================================
  Files         380      381    +1     
  Lines       48356    48447   +91     
=======================================
+ Hits        13370    13400   +30     
- Misses      34986    35047   +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jhugman jhugman force-pushed the jhugman/exp-3938-add-hash-to-fml-structure-and-defaults branch from d79df3a to b40ec3b Compare December 1, 2023 14:39
Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jhugman jhugman added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 8ded4cb Dec 1, 2023
16 checks passed
@jhugman jhugman deleted the jhugman/exp-3938-add-hash-to-fml-structure-and-defaults branch December 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants