Add a structure hash to FeatureInspector #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5949 +/- ##
==========================================
+ Coverage 26.97% 27.34% +0.37%
==========================================
Files 377 379 +2
Lines 47881 48145 +264
==========================================
+ Hits 12916 13166 +250
- Misses 34965 34979 +14 ☔ View full report in Codecov by Sentry. |
jhugman
force-pushed
the
jhugman/exp-3938-add-structure-hasher
branch
from
79cd3ac
to
48bc961
Compare
eliserichards
approved these changes
Nov 29, 2023
| @@ -66,6 +66,12 @@ impl FmlFeatureInspector { | |||
| pub fn get_errors(&self, string: String) -> Option<Vec<FmlEditorError>> { | |||
| self.get_first_error(string).map(|e| vec![e]) | |||
| } | |||
|
|
|||
| pub fn get_structure_hash(&self) -> String { | |||
There was a problem hiding this comment.
I definitely agree that "structure" isn't as clear as I'd like it to be
There was a problem hiding this comment.
"Schema" does seem like a good alternative, since we use "definition" in other places
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to EXP-3938.
According to The Big O of Code Reviews, this is a O(n) change.
This PR adds:
TypeQueryutility for getting allTypeRefs that aFeatureDefuses, including recursively looking atObjectDefs. This is useful in multiple places, so good to pull this out.Sha256Hasher, compatible withstd:hash:HashStructureHasherthat uses the structure of the feature (and embedded Objects).It exposes
get_structure_hash()to theFeatureInspector, available to python.Pull Request checklist
[ci full]to the PR title.Branch builds: add
[firefox-android: branch-name]to the PR title.