Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename structure --> schema #5959

Merged
merged 1 commit into from Nov 30, 2023

Conversation

jhugman
Copy link
Contributor

@jhugman jhugman commented Nov 29, 2023

Relates to EXP-3938.

According to The Big O of Code Reviews, this is a O(1) change.

This PR touches a lot of files, but is a wholy mechanical change, done by search and replace and IDE changes.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due dilligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@jhugman jhugman added the nimbus Nimbus, the experimentation platform. label Nov 29, 2023
@jhugman jhugman force-pushed the jhugman/exp-3938-rename-structure-to-schema branch from 05e655a to 7e13a2f Compare November 29, 2023 20:44
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b518395) 27.35% compared to head (7e13a2f) 27.35%.
Report is 1 commits behind head on main.

Files Patch % Lines
...port/nimbus-fml/src/intermediate_representation.rs 20.00% 4 Missing ⚠️
...ponents/support/nimbus-fml/src/client/inspector.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5959   +/-   ##
=======================================
  Coverage   27.35%   27.35%           
=======================================
  Files         379      379           
  Lines       48131    48131           
=======================================
  Hits        13166    13166           
  Misses      34965    34965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jeddai jeddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

@@ -315,7 +315,7 @@ impl FeatureManifest {
}

fn validate_structure(&self) -> Result<(), FMLError> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be validate_schema?

@jhugman jhugman force-pushed the jhugman/exp-3938-rename-structure-to-schema branch from 7e13a2f to ba4d5fb Compare November 30, 2023 01:06
@jhugman jhugman force-pushed the jhugman/exp-3938-rename-structure-to-schema branch from ba4d5fb to 71e359e Compare November 30, 2023 01:08
@jhugman jhugman added this pull request to the merge queue Nov 30, 2023
Merged via the queue into main with commit 59c6820 Nov 30, 2023
16 checks passed
@jhugman jhugman deleted the jhugman/exp-3938-rename-structure-to-schema branch November 30, 2023 01:42
@jhugman jhugman mentioned this pull request Nov 30, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nimbus Nimbus, the experimentation platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants