Fixes DISCO-2712: Add an ON DELETE CASCADE action to prefix_keywords.suggestion_id. (backport #6016)
#6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
This missing action caused "FOREIGN KEY constraint failed" errors when re-ingesting AMO and Pocket suggestions. AMP and Wikipedia suggestions are unaffected, because they store their keywords in the `keywords` table, and `keywords.suggestion_id` has the action. (cherry picked from commit d631ec1)
5 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-v122 #6028 +/- ##
================================================
- Coverage 27.58% 27.55% -0.03%
================================================
Files 392 392
Lines 49044 49091 +47
================================================
Hits 13529 13529
- Misses 35515 35562 +47 ☔ View full report in Codecov by Sentry. |
DonalMe
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6016 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com