Truncate floats provided to bucketSample transform (backport #6083) #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
The original implementation forbade floats and assumed that all inputs would be integers. However, the start param is most likely always going to be a floating point number in practice. We now support floats for the `start`, `count`, and `total` args and truncate them to u32. Fixes bug 1877255 (cherry picked from commit 7b32ce2)
5 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-v123 #6087 +/- ##
================================================
- Coverage 27.63% 27.62% -0.01%
================================================
Files 398 398
Lines 50200 50212 +12
================================================
Hits 13872 13872
- Misses 36328 36340 +12 ☔ View full report in Codecov by Sentry. |
pascalchevrel
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #6083 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com