Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createBookmarkItem in android places. Fixes #880 #881

Merged
merged 1 commit into from Mar 29, 2019
Merged

Fix createBookmarkItem in android places. Fixes #880 #881

merged 1 commit into from Mar 29, 2019

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Mar 29, 2019

Pull Request checklist

  • Quality: This PR builds and tests run cleanly
    • cargo test --all produces no test failures
    • cargo clippy --all --all-targets --all-features runs without emitting any warnings
    • cargo fmt does not produce any changes to the code
    • ./gradlew ktlint detekt runs without emitting any warnings
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly

vladikoff
vladikoff approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@vladikoff vladikoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colintheshots please let us know if you need a point release for a-s to unblock your work

@thomcc
Copy link
Contributor Author

thomcc commented Mar 29, 2019

Push landed a breaking change so it wouldn't be a point release, but yes, still this.

@thomcc thomcc merged commit a16f7dc into master Mar 29, 2019
@thomcc thomcc deleted the create-nodetypes branch March 29, 2019 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladikoff vladikoff vladikoff approved these changes

@colintheshots colintheshots Awaiting requested review from colintheshots

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomcc @vladikoff