Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] PlacesConnection.createBookmark() creates a separator #880

Closed
colintheshots opened this issue Mar 29, 2019 · 0 comments
Closed

[Bug] PlacesConnection.createBookmark() creates a separator #880

colintheshots opened this issue Mar 29, 2019 · 0 comments
Assignees
@thomcc

Comments

@colintheshots
Copy link

PlacesConnection.createBookmark() does not create a Bookmark, but actually a separator.

application-services/components/places/android/src/main/java/mozilla/appservices/places/PlacesConnection.kt

Line 411 in 7452d4b

.setNodeType(BookmarkType.Separator.value)

@thomcc thomcc self-assigned this Mar 29, 2019
@thomcc thomcc closed this as completed in f5a4520 Mar 29, 2019
thomcc added a commit that referenced this issue Mar 29, 2019
@thomcc
Merge pull request #881 from mozilla/create-nodetypes
a16f7dc 
Fix createBookmarkItem in android places. Fixes #880
@bbinto bbinto mentioned this issue Mar 29, 2019
Closed
colintheshots added a commit to colintheshots/android-components that referenced this issue Mar 29, 2019
@colintheshots
Upgrading A-S Fixes mozilla/application-services#880: [Bug] createBoo…
9240ab7 
…kmark() creates a separator
jonalmeida pushed a commit to mozilla-mobile/android-components that referenced this issue Mar 29, 2019
@colintheshots @jonalmeida
Upgrading A-S Fixes mozilla/application-services#880: [Bug] createBoo…
a0dfd43 
…kmark() creates a separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomcc thomcc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colintheshots @thomcc