This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
[bug 1179878] Pass user agent info from FxA to Exact Target. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertEqual(record['DEVICE_NAME'], 'Generic Smartphone') | ||
| self.assertEqual(record['DEVICE_TYPE'], 'M') | ||
|
|
||
| # TODO This reports Android 5 instead of Firefox 40 |
There was a problem hiding this comment.
I didn't manage to get this working. ua_parse lib seems to get this wrong for both chrome and firefox. Filed bug ua-parser/uap-core#77
|
added |
|
Excellent work! 🎯 |
pmclanahan
pushed a commit
that referenced
this pull request
Sep 11, 2015
…1179878 [bug 1179878] Pass user agent info from FxA to Exact Target.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ua-parseanduser-agentspython libs. Depends on [bug 1179878] Parse user agents. basket-lib#22