[fix bug 1121733] Tabs missing from /firefox/tips pages

mozilla · Jan 15, 2015 · 3b032f0 · 3b032f0
1 parent 75eab2e
commit 3b032f0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/bedrock/firefox/templates/firefox/desktop/tips.html b/bedrock/firefox/templates/firefox/desktop/tips.html
@@ -40,7 +40,7 @@ <h2>{{ _('5 top tips, tricks and time-saving tools') }}</h2>
         </div>
       </div>
 
-      <div id="share-nav-wrapper" class="share-wrapper">
+      <div id="main-nav-wrapper" class="button-wrapper">
         {% include 'firefox/includes/social-share.html' %}
         <nav id="tips-nav-direct">
           <ol role="tablist">
@@ -249,7 +249,7 @@ <h3>{{ _('Congratulations') }}</h3>
           {{ _('You’re an expert!') }}
           {{ _('Now help your friends master Firefox.') }}
         </p>
-        <div class="share-wrapper">
+        <div class="button-wrapper">
           {% include 'firefox/includes/social-share.html' %}
         </div>
       </div>

diff --git a/media/css/firefox/desktop/tips.less b/media/css/firefox/desktop/tips.less
@@ -138,7 +138,7 @@
     }
 }
 
-#share-nav-wrapper {
+#main-nav-wrapper {
     .clearfix();
 
     .socialshare {
@@ -413,7 +413,7 @@ html[dir='rtl'] {
         margin-left: @baseLine;
     }
 
-    #share-nav-wrapper .socialshare {
+    #main-nav-wrapper .socialshare {
         float: right;
     }
 
@@ -505,7 +505,7 @@ html[dir='rtl'] {
             .font-size(22px);
         }
 
-        #share-nav-wrapper {
+        #main-nav-wrapper {
             margin: -20px 156px 0 0;
 
             .socialshare {

diff --git a/media/js/firefox/desktop/tips.js b/media/js/firefox/desktop/tips.js
@@ -162,7 +162,7 @@
         // GA tracking
         $('.share-button').on('click', function() {
             // determine position
-            var pos = ($(this).closest('.share-wrapper').prop('id') === 'share-nav-wrapper') ? 'top' : 'bottom';
+            var pos = ($(this).closest('.button-wrapper').prop('id') === 'main-nav-wrapper') ? 'top' : 'bottom';
 
             gaTrack(['_trackEvent','/desktop/tips/ Interactions','Social Share', 'share drop-down ' + pos]);
         });