Merge pull request #3982 from analytics-pros/bug-1248040-firefox-desk…

…top-customize [bug 1248040] Update GTM data attributes on /firefox/dekstop/customiz…
mozilla · Mar 17, 2016 · 7d144c3 · 7d144c3
2 parents 1c99122 + a4f331a
commit 7d144c3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/bedrock/firefox/templates/firefox/desktop/customize.html b/bedrock/firefox/templates/firefox/desktop/customize.html
@@ -117,7 +117,7 @@ <h2>{{ _('More ways to customize') }}</h2>
 
       <ul class="feature-list" id="customizer-list" role="tablist">
         <li>
-          <a class="show-customizer selected" data-interaction="themes" data-element-action="Icon" id="customize-themes" href="#themes">
+          <a class="show-customizer selected" data-link-type="button" data-link-name="Themes" id="customize-themes" href="#themes">
             <div class="stage">
               <div class="circle-mask"></div>
               <div id="brush"></div>
@@ -129,7 +129,7 @@ <h2>{{ _('More ways to customize') }}</h2>
           </a>
         </li>
         <li>
-          <a class="show-customizer" data-interaction="add-ons" data-element-action="Icon" id="customize-addons" href="#add-ons">
+          <a class="show-customizer" data-link-type="button" data-link-name="Add-ons" id="customize-addons" href="#add-ons">
             <div class="stage">
               <div class="circle-mask"></div>
               <div id="puzzle-pieces">
@@ -141,7 +141,7 @@ <h2>{{ _('More ways to customize') }}</h2>
           </a>
         </li>
         <li class="last">
-          <a class="show-customizer" data-interaction="awesome-bar" data-element-action="Icon" id="customize-awesomebar" href="#awesome-bar">
+          <a class="show-customizer" data-link-type="button" data-link-name="Awesome Bar" id="customize-awesomebar" href="#awesome-bar">
             <div class="stage">
               <div class="circle-mask"></div>
               <div id="awesomebar-on" class="awesomebar-icon"></div>
@@ -246,7 +246,7 @@ <h2>{{ _('Keep your Firefox in Sync') }}</h2>
 
       {% include 'firefox/includes/sync-animation.html' %}
 
-      <a class="button" id="sync-button" data-interaction="button click" data-element-action="Sync CTA" href="http://www.mozilla.org/mobile/sync/"><span></span>{{ _('Learn more about Sync') }}</a>
+      <a class="button" id="sync-button" href="http://www.mozilla.org/mobile/sync/" data-link-type="button" data-link-name="Learn more about Sync"><span></span>{{ _('Learn more about Sync') }}</a>
       <br>
       <a class="more" rel="external" data-interaction="outbound link" href="https://support.mozilla.org/kb/how-do-i-set-up-firefox-sync">{{ _('Get help with Sync') }}</a>
     </div>

diff --git a/media/js/firefox/desktop/common.js b/media/js/firefox/desktop/common.js
@@ -19,15 +19,6 @@
 
         // show download button in sticky nav on overview page
         $('#sticky-download-desktop').fadeIn('fast');
-
-        // Track clicks on Nav CTA
-        $('#sticky-download-desktop .download-link').attr('data-interaction', 'download click - nav');
-
-        // Track Firefox download click in overview intro section
-        $('#firefox-desktop #intro .download-link').attr({'data-interaction': 'download click - primary', 'data-download-version': downloadVersion});
-
-        // Track Firefox download click in footer
-        $('#subscribe-download-wrapper .download-link').attr({'data-interaction': 'download click - bottom', 'data-download-version': downloadVersion});
     }
 
     // only show download buttons for users on desktop platforms, using either a non-Firefox browser