Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused picto card code from Privacy Products JS #10731

Closed
2 tasks
maureenlholland opened this issue Nov 11, 2021 · 3 comments · Fixed by #10775
Closed
2 tasks

Remove unused picto card code from Privacy Products JS #10731

maureenlholland opened this issue Nov 11, 2021 · 3 comments · Fixed by #10775
Labels
Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome Papercuts 💸 Tech debt payoff

Comments

@maureenlholland
Copy link
Contributor

maureenlholland commented Nov 11, 2021

We updated our code to use Picto components after Picto Cards were deprecated.

A side effect of this was breaking the Picto Card Title JS selector in Firefox's Privacy Products page

Because we already have two links allowing users to open the Protection Report on this page. We don't need to reinstate title links. The Picto Card JS code should be removed.

To set up UITour locally: https://bedrock.readthedocs.io/en/latest/uitour.html#local-development

Success Criteria:

ℹ️ The Protection Report is part of a Firefox user's about:protections page. This will not be available on other browsers. When you click "See what Firefox has blocked for you", you should see something like this:
firefox protection dashboard, personal to each user

@maureenlholland maureenlholland added Papercuts 💸 Tech debt payoff Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome labels Nov 11, 2021
@menghif
Copy link
Contributor

menghif commented Nov 16, 2021

@maureenlholland Hi, I'm trying to reproduce this locally but when I click on "See what Firefox has blocked for you" it takes me to the support page instead of about:protections.

Mozilla.UITour.showProtectionReport() returns 'undefined' instead of taking me to about:protections.

Is there any steps I am missing?

@maureenlholland
Copy link
Contributor Author

Is there any steps I am missing?

@menghif great question - yes, I've linked it in the description now. There are some changes to you have to make in your Firefox config to get UITour working locally, relevant part of the docs below:

Local development

To develop or test using Mozilla.UITour locally you need to create some custom preferences in about:config.

browser.uitour.testingOrigins (string) (value: local address e.g. http://127.0.0.1:8000)
browser.uitour.requireSecure (boolean) (value: false)

@menghif
Copy link
Contributor

menghif commented Nov 17, 2021

Thank you for your help @maureenlholland! I'm sending a PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Bug Folks wanting to contribute and learning bedrock can take on easier bugs as leads into the system Help wanted 👋 Community contributions welcome Papercuts 💸 Tech debt payoff
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants