Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old PictoCard code from Firefox Privacy Products JS #10775

Merged
merged 1 commit into from Nov 17, 2021

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Nov 17, 2021

Description

This PR removes unused PictoCard code from Firefox Privacy Products JS code:

  • Firefox Privacy Products JS code no longer references Picto Cards.

  • Firefox Privacy Product page still shows Protection Report when users click on "See what Firefox has blocked for you" while using a Firefox Browser.

Issue / Bugzilla link

Fixes: #10731

Testing

All tests passed.

@maureenlholland maureenlholland self-assigned this Nov 17, 2021
Copy link
Contributor

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🧹

Nice work, this will merge as soon as CI tests pass! Thanks @menghif

@maureenlholland maureenlholland merged commit 6f767de into mozilla:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused picto card code from Privacy Products JS
2 participants