Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap generation fails after refactor to use Django's i18n logic #14480

Closed
stevejalim opened this issue Apr 19, 2024 · 1 comment · Fixed by #14481
Closed

Sitemap generation fails after refactor to use Django's i18n logic #14480

stevejalim opened this issue Apr 19, 2024 · 1 comment · Fixed by #14481
Assignees
Labels
Bug 🐛 Something's not working the way it should P1 First level priority - Must have

Comments

@stevejalim
Copy link
Collaborator

Description

After #14256 landed, we noticed that www-sitemap-generator was failing.

Looking at it, it appears to be because the use of a URLResolver to get all the paths in the site now automatically includes the default language code (en-US) which means that paths that previously were /some/path/ and could have any lang code prepended to them are now generated as /en-US/some/path, which becomes, say, /sco/en-US/some/path/ which 404s when we try to update the etag for each page.

@stevejalim stevejalim added the Bug 🐛 Something's not working the way it should label Apr 19, 2024
@stevejalim stevejalim self-assigned this Apr 19, 2024
@stevejalim stevejalim added the P1 First level priority - Must have label Apr 19, 2024
@stevejalim
Copy link
Collaborator Author

I'm actively working on this now - fixup PR due very soon

stevejalim added a commit to stevejalim/bedrock that referenced this issue Apr 19, 2024
…mitted in sitemap.json

...so that we don't break www-sitemap-generator when it then prepends various locales to the URLs

Fixes mozilla#14480
stevejalim added a commit that referenced this issue Apr 19, 2024
* Add comment to help future selves

* Stop automatically prepending the default language code on the URLs emitted in sitemap.json

...so that we don't break www-sitemap-generator when it then prepends various locales to the URLs

Fixes #14480
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should P1 First level priority - Must have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant