You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #14256 landed, we noticed that www-sitemap-generator was failing.
Looking at it, it appears to be because the use of a URLResolver to get all the paths in the site now automatically includes the default language code (en-US) which means that paths that previously were /some/path/ and could have any lang code prepended to them are now generated as /en-US/some/path, which becomes, say, /sco/en-US/some/path/ which 404s when we try to update the etag for each page.
The text was updated successfully, but these errors were encountered:
* Add comment to help future selves
* Stop automatically prepending the default language code on the URLs emitted in sitemap.json
...so that we don't break www-sitemap-generator when it then prepends various locales to the URLs
Fixes#14480
Description
After #14256 landed, we noticed that www-sitemap-generator was failing.
Looking at it, it appears to be because the use of a URLResolver to get all the paths in the site now automatically includes the default language code (
en-US
) which means that paths that previously were/some/path/
and could have any lang code prepended to them are now generated as/en-US/some/path
, which becomes, say,/sco/en-US/some/path/
which 404s when we try to update the etag for each page.The text was updated successfully, but these errors were encountered: