Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language switcher no longer works without JavaScript #5931

Closed
alexgibson opened this issue Jul 17, 2018 · 4 comments
Closed

Language switcher no longer works without JavaScript #5931

alexgibson opened this issue Jul 17, 2018 · 4 comments
Labels
Bug 🐛 Something's not working the way it should Help wanted 👋 Community contributions welcome

Comments

@alexgibson
Copy link
Member

alexgibson commented Jul 17, 2018

This may well be an intended change reading #5581, but I'm filing this as not 100% sure.

STR:

Using any browser with JS disabled, or a legacy browser such as IE8 (where we don't serve JS):

1.) Visit https://www.mozilla.org/en-US/
2.) Scroll down to the language switcher in the footer and choose "Francais" from the list (as an example).
3.) Hit the "Go" button to submit the form.

Expected results:

Page should redirect to https://www.mozilla.org/fr/

Actual results:

Page redirects to https://www.mozilla.org/en-US/?lang=fr (still English)

If we no longer want to support the language switcher without JavaSctipt that's OK by me, but we should probably then hide it by default, rather than leave it in a broken state.

@alexgibson alexgibson added the Bug 🐛 Something's not working the way it should label Jul 17, 2018
@michaelmccombie
Copy link

Once we have the language selector page #5827 built out and added to the new footer mozilla/protocol#184 we will be able to provide that same functionality to those who have javascript disabled.

@conradylx
Copy link
Contributor

I think this issue is already fixed.

@robhudson
Copy link
Member

Tested this today and it is still an issue.

@maureenlholland maureenlholland added the Help wanted 👋 Community contributions welcome label Mar 30, 2023
Ingi-Hong added a commit to Ingi-Hong/bedrock that referenced this issue Jul 1, 2023
@stevejalim
Copy link
Collaborator

FYI i'm going to fold this work into my i18n-refactor work for #14256 - thanks for the contribution @Ingi-Hong

stevejalim added a commit that referenced this issue Mar 18, 2024
stevejalim added a commit that referenced this issue Mar 18, 2024
stevejalim added a commit that referenced this issue Mar 19, 2024
stevejalim added a commit that referenced this issue Mar 19, 2024
stevejalim added a commit that referenced this issue Mar 20, 2024
stevejalim added a commit that referenced this issue Mar 24, 2024
stevejalim added a commit that referenced this issue Mar 25, 2024
stevejalim added a commit that referenced this issue Apr 3, 2024
stevejalim added a commit that referenced this issue Apr 10, 2024
stevejalim added a commit that referenced this issue Apr 15, 2024
stevejalim added a commit that referenced this issue Apr 16, 2024
stevejalim added a commit that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Something's not working the way it should Help wanted 👋 Community contributions welcome
Projects
None yet
Development

No branches or pull requests

6 participants