Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding /all #7076

Closed
4 of 7 tasks
ejregithub opened this issue Apr 15, 2019 · 27 comments
Closed
4 of 7 tasks

Coding /all #7076

ejregithub opened this issue Apr 15, 2019 · 27 comments
Assignees
Labels
Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. P3 Third level priority - Nice to have

Comments

@ejregithub
Copy link
Contributor

ejregithub commented Apr 15, 2019

Description

Coding the the /all page with new design and copy


💛 Success Criteria 💛

  • Page is live and open for localization by end of sprint.
  • Fallback to existing content until locales (per locale basis) are to 100%
  • Can deep link to a specific configuration
  • OS is detected, pre-selected (but still changeable)
  • OS dropdown is sorted by OS, so 32/64 are clustered together

Tasks

  • Code the page
  • Extract strings to Pontoon for L10n, notify L10n team when strings are ready
@ejregithub ejregithub added P1 First level priority - Must have Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. labels Apr 15, 2019
@craigcook craigcook self-assigned this Apr 23, 2019
@hoosteeno
Copy link
Contributor

@craigcook

  • I captured the feedback from design doc in the success criteria above. Please let me know if you have questions.
  • I also added a blocker for the copy card.

@ejregithub
Copy link
Contributor Author

Moving this to the next milestone. Copy won't be complete til later today, the last day of the sprint, and per discussion with Craig on the progress of coding.

@hoosteeno
Copy link
Contributor

Dragging this back into backlog so @alexgibson can pick it up next.

@hoosteeno hoosteeno added P3 Third level priority - Nice to have and removed P1 First level priority - Must have labels May 13, 2019
@alexgibson alexgibson assigned alexgibson and unassigned craigcook May 14, 2019
@alexgibson
Copy link
Member

alexgibson commented May 14, 2019

@craigcook do you have a branch containing your WIP on this? If so, I can pull it down and build upon it. Thanks

@alexgibson
Copy link
Member

Relevant links:

craigcook added a commit to craigcook/bedrock that referenced this issue May 14, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 16, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 21, 2019
@alexgibson
Copy link
Member

alexgibson commented May 21, 2019

WIP version is finally up on demo for design/copy/UX review:

https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/all/

Some notes:

Things still to do:

  • Pre-select operating system choice on page load (it currently defaults to Windows 64bit).
  • Updated based on feedback.
  • Analytics requirements.
  • Write tests.

@rraue
Copy link
Contributor

rraue commented May 21, 2019

We should have links to learn more for all editions in this info box:
Screenshot 2019-05-21 at 17 53 06

@craigcook
Copy link
Member

We should have links to learn more for all editions in this info box:

Do we have pages to link to for all of these? We have a product page for Dev Edition, and there's a page at /firefox/enterprise that might work for ESR. I don't know that we have informative pages for Beta or Nightly.

@alexgibson
Copy link
Member

It's not perfect, but perhaps we can do the following:

  • Firefox: /firefox/
  • Firefox Beta: /firefox/channel/desktop/#beta
  • Firefox Developer Edition: /firefox/developer/
  • Firefox Nightly: /firefox/channel/desktop/#nightly
  • Firefox ESR: /firefox/organizations/ (Firefox Enterprise isn't really a channel like ESR)
  • Firefox Android: /firefox/mobile/
  • Firefox Android Beta /firefox/channel/android/#beta
  • Firefox Android Nightly /firefox/channel/android/#nightly

@rraue
Copy link
Contributor

rraue commented May 21, 2019

Thats exactly what I though of @alexgibson. Why isnt ios included there? Shouldnt we include it and then send them to the app store? I know we cant serve the ios build and it makes it more complicated.

@rraue
Copy link
Contributor

rraue commented May 21, 2019

Here are the two things we talked in slack about @alexgibson:

  • Canonical: as /beta/all/, /nightly/all/ and all other right now existing pages will be not transferred right away, when we push out the new /all/ we should include in all templates a canonical to /locale/firefox/all/ so we do not produce dublicate content. Then when these pages are all set, we redirect them to locale/firefox/all/

  • Title: I talked with @amychurchwell about it and would like to have the same language string in the title like we use in the dropdown on the new /all/ and like we use in the language switcher in the footer. The /all/ page gets a good amount of search traffic because users search explicitly for "firefox language" and we are not using the language anywhere else in the title, so this is a extra incentive to click on /all/ instead of on some other website being explicit about the language.

@alexgibson
Copy link
Member

Why isnt ios included there? Shouldnt we include it and then send them to the app store? I know we cant serve the ios build and it makes it more complicated.

We don't serve builds for iOS directly from mozorg, but I think you're right we do need to do something for iOS users. Perhaps we can include some conditional string to explain that links over to the app store.

@hoosteeno
Copy link
Contributor

hoosteeno commented May 21, 2019

Nice. I am very happy with the way this is shaping up.

  • Is there a reason to omit the global accounts CTA from this page?
  • How is the download button instrumented -- does it cause GA events to fire? Do events match the download (e.g. nightly vs. release)?
  • What do we have to do to get MSI downloads here? That was one of the original justifications for this redesign.
  • One of the features we have wanted here is a deep link to a specific configuration. What's the status of that?

@rraue
Copy link
Contributor

rraue commented May 21, 2019

One more detail:

<a href="https://download.mozilla.org/?product=firefox-latest-ssl&amp;os=osx&amp;lang=ach" title="Download for macOS in Acholi" data-download-version="osx" data-download-language="acholi" data-link-type="download" data-download-os="Desktop">macOS </a>

I would like to include here in the title the firefox prduct so the sentence most users are searching for is at least once completly in the document, even if its just in the link-title. For example:

<a href="https://download.mozilla.org/?product=firefox-latest-ssl&amp;os=osx&amp;lang=ach" title="Download Firefox beta for macOS in Acholi" data-download-version="osx" data-download-language="acholi" data-link-type="download" data-download-os="Desktop">macOS </a>

@alexgibson
Copy link
Member

alexgibson commented May 21, 2019

Is there a reason to omit the global accounts CTA from this page?

Right now I'm hiding the global nav download button / accounts CTA, as the download button is confusing in context of the page. To pick apart that functionality so we can only show the accounts CTA is possible, but not something I'd want to add scope in doing here.

How is the download button instrumented -- does it cause GA events to fire? Do events match the download (e.g. nightly vs. release)?

Right now I'm just making up data-attributes. I could use some help from maybe AP to confirm what I'm doing is ok.

What do we have to do to get MSI downloads here? That was one of the original justifications for this redesign.

We have to do the work to add those installers. This redesign is already large enough I'm not going to add scope here by piling on more features. I'd suggest a followup issue for doing this, although it may also need to wait until we can safely retire the old page.

One of the features we have wanted here is a deep link to a specific configuration. What's the status of that?

Other than the brief mention in the description above, I have zero information on how this is supposed to work. Right now, there is no deep linking. I'd suggest writing up some proposed functionality, and filing a separate issue for it. I'd imagine it may need to be built on fragment identifiers or url params, seeing as this all now lives at one URL for SEO.

@alexgibson
Copy link
Member

alexgibson commented May 21, 2019

One more detail:

I would like to include here in the title the firefox prduct so the sentence most users are searching for is at least once completly in the document, even if its just in the link-title. For example:

I'll see what I can work out here. I'm going to say no to changing the link text, to keep things readable for humans. Doing this in the title attribute may be OK though.

@rraue
Copy link
Contributor

rraue commented May 21, 2019

I'm going to say no to changing the link text

We agree on this, just the title, not the link text, like in my example.

alexgibson added a commit to alexgibson/bedrock that referenced this issue May 24, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 24, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 24, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 24, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 24, 2019
@alexgibson
Copy link
Member

@hoosteeno is it possible to enlist the help of Analytics Pros to QA that we're still counting downloads correctly on this new page? I think I've followed everything as closely as I can in terms of how regular download buttons work, but it would be good to get someone to help verify? Thanks

@hoosteeno
Copy link
Contributor

hoosteeno commented May 24, 2019

@apwescontreras or @SirDudeness, could you take a quick look at the demo page and let us know how the instrumentation looks? We want to capture the data in the dropdowns in the same way we have been on the existing pages.

@alexgibson
Copy link
Member

@apwescontreras or @SirDudeness, could you take a quick look at the demo page and let us know how the instrumentation looks? We want to capture the data in the dropdowns in the same way we have been on the existing pages.

To be clear, we would like to verify that when someone clicks the blue "Download Now" button, the correct data attributes have been set (e.g. for product, platform, language etc). The data that gets passed on when clicking "Download Now" should be consistent with how other download buttons are tracked in general. Thanks

alexgibson added a commit to alexgibson/bedrock that referenced this issue May 28, 2019
@alexgibson
Copy link
Member

This issue is not complete until it is merged, and we're still waiting on input from AP. Reopening.

@alexgibson alexgibson reopened this May 28, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 29, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 29, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 30, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue May 30, 2019
@hoosteeno
Copy link
Contributor

Here is AP feedback:

  • We need to change the datalayer variable name associated with language. It should be data-download-language.

Otherwise, the code looks good from an instrumentation perspective.

alexgibson added a commit to alexgibson/bedrock that referenced this issue May 31, 2019
@alexgibson
Copy link
Member

Thanks, updated! This is now good to merge once it gets code review.

@hoosteeno
Copy link
Contributor

hoosteeno commented May 31, 2019

We have a modified rollout plan for this page:

  1. Merge, deploy for en-US
  2. Iterate on UI to be sure it can incorporate MSI installers (and future installer types)
  3. Adjust product-details to include MSI installers
  4. Merge, deploy for global l10n

@hoosteeno
Copy link
Contributor

Seealso: #7266

alexgibson added a commit to alexgibson/bedrock that referenced this issue Jun 3, 2019
alexgibson added a commit to alexgibson/bedrock that referenced this issue Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moz.org Self-initiated projects, such as site-wide improvements, navigation/IA, code cleanup, etc. P3 Third level priority - Nice to have
Projects
None yet
Development

No branches or pull requests

6 participants