New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding /all #7076
Comments
|
Moving this to the next milestone. Copy won't be complete til later today, the last day of the sprint, and per discussion with Craig on the progress of coding. |
Dragging this back into backlog so @alexgibson can pick it up next. |
@craigcook do you have a branch containing your WIP on this? If so, I can pull it down and build upon it. Thanks |
Relevant links: |
WIP version is finally up on demo for design/copy/UX review: https://bedrock-demo-agibson.oregon-b.moz.works/en-US/firefox/all/ Some notes: Things still to do:
|
Do we have pages to link to for all of these? We have a product page for Dev Edition, and there's a page at /firefox/enterprise that might work for ESR. I don't know that we have informative pages for Beta or Nightly. |
It's not perfect, but perhaps we can do the following:
|
Thats exactly what I though of @alexgibson. Why isnt ios included there? Shouldnt we include it and then send them to the app store? I know we cant serve the ios build and it makes it more complicated. |
Here are the two things we talked in slack about @alexgibson:
|
We don't serve builds for iOS directly from mozorg, but I think you're right we do need to do something for iOS users. Perhaps we can include some conditional string to explain that links over to the app store. |
Nice. I am very happy with the way this is shaping up.
|
One more detail:
I would like to include here in the title the firefox prduct so the sentence most users are searching for is at least once completly in the document, even if its just in the link-title. For example:
|
Right now I'm hiding the global nav download button / accounts CTA, as the download button is confusing in context of the page. To pick apart that functionality so we can only show the accounts CTA is possible, but not something I'd want to add scope in doing here.
Right now I'm just making up data-attributes. I could use some help from maybe AP to confirm what I'm doing is ok.
We have to do the work to add those installers. This redesign is already large enough I'm not going to add scope here by piling on more features. I'd suggest a followup issue for doing this, although it may also need to wait until we can safely retire the old page.
Other than the brief mention in the description above, I have zero information on how this is supposed to work. Right now, there is no deep linking. I'd suggest writing up some proposed functionality, and filing a separate issue for it. I'd imagine it may need to be built on fragment identifiers or url params, seeing as this all now lives at one URL for SEO. |
I'll see what I can work out here. I'm going to say no to changing the link text, to keep things readable for humans. Doing this in the title attribute may be OK though. |
We agree on this, just the title, not the link text, like in my example. |
@hoosteeno is it possible to enlist the help of Analytics Pros to QA that we're still counting downloads correctly on this new page? I think I've followed everything as closely as I can in terms of how regular download buttons work, but it would be good to get someone to help verify? Thanks |
@apwescontreras or @SirDudeness, could you take a quick look at the demo page and let us know how the instrumentation looks? We want to capture the data in the dropdowns in the same way we have been on the existing pages. |
To be clear, we would like to verify that when someone clicks the blue "Download Now" button, the correct data attributes have been set (e.g. for product, platform, language etc). The data that gets passed on when clicking "Download Now" should be consistent with how other download buttons are tracked in general. Thanks |
This issue is not complete until it is merged, and we're still waiting on input from AP. Reopening. |
Here is AP feedback:
Otherwise, the code looks good from an instrumentation perspective. |
Thanks, updated! This is now good to merge once it gets code review. |
We have a modified rollout plan for this page:
|
Seealso: #7266 |
Description
Coding the the /all page with new design and copy
💛 Success Criteria 💛
Tasks
The text was updated successfully, but these errors were encountered: