Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery from common bundle (Fixes #9946) #10309

Merged
merged 1 commit into from Jul 9, 2021
Merged

Remove jQuery from common bundle (Fixes #9946) #10309

merged 1 commit into from Jul 9, 2021

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jul 5, 2021 •
edited

Description

  • Removes jQuery from common.js bundle 馃帀 .
  • Allow Convert to supply its own copy of jQuery since we will now no longer have duplication going on.

Issue / Bugzilla link

#9946

Testing

Successful test run: https://gitlab.com/mozmeao/www-config/-/pipelines/332000843

Demo: https://www-demo3.allizom.org/en-US/

@alexgibson alexgibson force-pushed the remove-jquery branch 3 times, most recently from f05624b to 8773300 Compare July 5, 2021 14:30
@alexgibson alexgibson marked this pull request as ready for review July 5, 2021 15:14
@alexgibson alexgibson added Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min labels Jul 5, 2021
@mozmeao-heroku-bot mozmeao-heroku-bot temporarily deployed to www-demo3 July 5, 2021 15:16 Inactive
@craigcook craigcook self-assigned this Jul 7, 2021
@alexgibson
Copy link
Member Author

Rebased

@mozmeao-heroku-bot mozmeao-heroku-bot temporarily deployed to www-demo3 July 9, 2021 08:31 Inactive
craigcook
craigcook approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃Ъ

@craigcook craigcook merged commit 04ef882 into mozilla:master Jul 9, 2021
@alexgibson alexgibson deleted the remove-jquery branch October 18, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigcook craigcook craigcook approved these changes

Assignees

@craigcook craigcook

Labels
Needs Review Awaiting code review P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexgibson @craigcook @mozmeao-heroku-bot