Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 764035 - [SEO] Implement schema.org for applications #1268

Merged
merged 1 commit into from Oct 10, 2013
Merged

Bug 764035 - [SEO] Implement schema.org for applications #1268

merged 1 commit into from Oct 10, 2013

Conversation

kyoshino
Copy link
Contributor

  • Reused the description of the page; no need for extra l10n
  • Declared both http://schema.org/SoftwareApplication and http://schema.org/Product in case
  • Structured Data Testing Tool

@alexgibson
Copy link
Member

Think this one looks ok - I wasn't sure at first about using the meta tags within the body of the page, but the examples on schema.org do the same and it does seem to be valid markup.

Since this will reuse the meta description string from the Firefox base template, is this one worth waiting on until bug 921603 lands, @jpetto?

@jpetto
Copy link
Contributor

jpetto commented Oct 1, 2013

I don't think there's any reason to wait on this one. The meta description string used here is just what @chrismore requested be used on /firefox/new/ (https://bugzilla.mozilla.org/show_bug.cgi?id=921603#c1).

Since /firefox/new/ already shares a meta description with all other /firefox/ URLs, I don't think adding this will do any harm regarding SEO.

Might want @chrismore to weigh in, but I think it's good to go.

@alexgibson
Copy link
Member

Well, this one is an r+ from me - unless @chrismore has anything further to add.

@chrismore
Copy link

I'm fine with this given bug 921603 will create unique descriptions. Having duplicate description can't hurt anymore than it is already now so let's move forward with schema.org.

alexgibson added a commit that referenced this pull request Oct 10, 2013
Bug 764035 - [SEO] Implement schema.org for applications
@alexgibson alexgibson merged commit a80d9a9 into mozilla:master Oct 10, 2013
@kyoshino kyoshino deleted the bug-764035-schema-apps branch October 10, 2013 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants