Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Traffic Cop to v3.0.0 (Fixes #14086) #14087

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Jan 16, 2024

One-line summary

  • Bumps Traffic Cop to v3.0.0 (which removes use of cookies).
  • Removes bedrock code that would try to read the TC custom referrer cookie (we can revisit this in the future to add back to bedrock if we find we need it).
  • Removes redundant id and cookieExpires properties from TC experiment configs.

Issue / Bugzilla link

#14086

Testing

First run make preflight.

The following URLs should still redirect to a variation as normal:

The main difference is that each time you hit one of the original URLs above, you may get redirected to a different version than before (since we no longer set a cookie to remember).

@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from 012f0a1 to ba6494c Compare January 16, 2024 16:32
@stephaniehobson stephaniehobson self-assigned this Jan 22, 2024
@alexgibson alexgibson force-pushed the traffic-cop branch 3 times, most recently from fc035ec to 73be86a Compare January 29, 2024 09:39
@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from bdeadec to 6f6d0f6 Compare February 5, 2024 14:33
@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from 2b1c571 to c012fce Compare February 12, 2024 13:37
@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from 8a1459d to 0b1ca05 Compare February 21, 2024 09:44
@alexgibson alexgibson force-pushed the traffic-cop branch 4 times, most recently from 7273bcd to be1b588 Compare February 28, 2024 09:08
@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from ff42caa to eefe643 Compare March 6, 2024 10:58
@alexgibson alexgibson force-pushed the traffic-cop branch 4 times, most recently from 622b8a7 to 24037c7 Compare March 15, 2024 16:09
@stephaniehobson stephaniehobson removed their assignment Mar 15, 2024
@alexgibson alexgibson force-pushed the traffic-cop branch 4 times, most recently from 7f8f7f6 to a7c62e4 Compare March 27, 2024 09:25
@alexgibson alexgibson force-pushed the traffic-cop branch 2 times, most recently from 731ced2 to 7315646 Compare April 4, 2024 08:12
@alexgibson alexgibson added P1 First level priority - Must have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Apr 29, 2024
@alexgibson alexgibson marked this pull request as ready for review April 29, 2024 09:05
@craigcook craigcook self-assigned this Apr 29, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👮

@craigcook craigcook merged commit 8fa3b01 into mozilla:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review P1 First level priority - Must have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants