Homepage and global nav updates #14552
Conversation
reemhamz
force-pushed
the
homepage-updates
branch
3 times, most recently
from
46196d6
to
e42ac02
Compare
reemhamz
force-pushed
the
homepage-updates
branch
from
493e6bf
to
4208ca4
Compare
reemhamz
added
Needs Review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14552 +/- ##
==========================================
+ Coverage 76.44% 76.78% +0.33%
==========================================
Files 148 152 +4
Lines 7987 8124 +137
==========================================
+ Hits 6106 6238 +132
- Misses 1881 1886 +5 ☔ View full report in Codecov by Sentry. |
bedrock/base/templates/includes/protocol/navigation/menus/innovation.html
Outdated
Show resolved
Hide resolved
bedrock/base/templates/includes/protocol/navigation/menus/products.html
Outdated
Show resolved
Hide resolved
| {% if switch('monitor-plus-banner') and LANG == 'en-US' %} | ||
| {{ css_bundle('monitor-banner')}} |
There was a problem hiding this comment.
Question: are we keeping this old banner around in case we end up using it, or is it safe to remove? (same for the other bits related to it below).
There was a problem hiding this comment.
Issue: at the bottom of the page I can still see the un-styled monitor banner, as the HTML include is still in the page:
There was a problem hiding this comment.
Checked with Emma, and she suggested we keep the banner code in Bedrock in case the Monitor team asks for it to be used once things are sorted out with the new provider
| <section class="c-mission"> | ||
|
|
||
| <!-- Trustworthy AI --> | ||
| {% call split( |
There was a problem hiding this comment.
Question: seeing as the Trustworthy AI and "What is Mozilla?" sections are new content, should we only show these splits if the page has them translated? Could we maybe fall back just to this for languages that don't yet have the new content translated?
There was a problem hiding this comment.
Great idea! I added the ftl_has_messages helper for the Trustworthy AI section, however I've already set the fallbacks for the "What is Mozilla?" section to be the former strings you screenshotted above strings
|
Oh looks like a functional test might also need updating? https://github.com/mozilla/bedrock/blob/main/tests/functional/test_home.py |
|
Looks like Dan approved things in the issue too, so I'm gonna merge this: #14543 (comment) |
One-line summary
Some updates came in for the homepage including some extra product info.
Significant changes and points to review
donate_urlhelper (made in this PR) and added thefeatured-sectionparamIssue / Bugzilla link
Fixes #14543
Testing