Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend 126beta WNP to 127beta [fix #14435] #14560

Merged
merged 1 commit into from May 13, 2024

Conversation

craigcook
Copy link
Member

One-line summary

Nimbus tooling is going to ride the beta train for another cycle so we need to extend the WNP for the next version. I kept it simple and didn't duplicate or rename the files, just expanded the view condition and added more tests.

Issue / Bugzilla link

#14435

Testing

http://localhost:8000/en-US/firefox/127.0beta/whatsnew/
http://localhost:8000/en-CA/firefox/127.0beta/whatsnew/
http://localhost:8000/en-GB/firefox/127.0beta/whatsnew/
http://localhost:8000/fr/firefox/127.0beta/whatsnew/
http://localhost:8000/de/firefox/127.0beta/whatsnew/

@craigcook craigcook added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.44%. Comparing base (bcdee9c) to head (f665d01).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14560   +/-   ##
=======================================
  Coverage   76.44%   76.44%           
=======================================
  Files         148      148           
  Lines        7987     7987           
=======================================
  Hits         6106     6106           
  Misses       1881     1881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alexgibson alexgibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@alexgibson alexgibson merged commit 9023d5e into mozilla:main May 13, 2024
5 checks passed
@craigcook craigcook deleted the 14435-wnp-127beta branch May 13, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants