migrate geolocation demo to google maps api v3 #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,6 +124,6 @@ <h4 class="expander-header">How do I turn off Location-Aware Browsing permanentl | |||
|
|
|||
| </div> <!-- end #main --> | |||
|
|
|||
| <script src="http://maps.google.com/maps?file=api&v=2&sensor=true&key={{ gmap_api_key }}"></script> | |||
| <script src="http://maps.googleapis.com/maps/api/js?sensor=true&key={{ gmap_api_key }}"></script> | |||
There was a problem hiding this comment.
Use a protocol-relative URL so that it works over http and https.
src="//maps.googleapis.com"
|
Thanks a lot! r+ with this small fix. |
|
Thanks for the review! The protocol part removed and the branch rebased onto the current master. |
rik
added a commit
that referenced
this pull request
Jun 15, 2012
migrate geolocation demo to google maps api v3
|
Awesome! If you're interested, I know this page would love a similar update: https://www.mozilla.org/en-US/about/contact.html It is in the PHP codebase though. We can discuss this by email (anthony@mozilla.com) or on IRC (#www, I'm Rik). |
|
Hi, Google Maps API v3 uses different key from v2, ref. An alert can be seen by visiting http://www-dev.allizom.org/en-US/firefox/geolocation/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Maps Javascript API v2 is long-deprecated1. This pull request update geolocation-demo.js with its v3 equivalent, with the exception of using v3's default control UI.